HHH-18764 Fix incorrect type resolution in ManyToOneType dirty check #9172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
approved these changes
Oct 28, 2024
Member
mbellade
left a comment
mbellade
left a comment
There was a problem hiding this comment.
LGTM, @stringintech could you please also test this on the 6.6 branch and provide a PR against it to backport the fix? Thanks!
Contributor
Author
|
Sure. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the
isDirtymethod when dealing with ManyToOne associations that are referenced by a unique key instead of a primary key, particularly when the primary key is a custom type.This bug stems from a mismatch in how
isDirtychecks for changes: while it correctly retrieves the unique key value usinggetIdentifier, it incorrectly relies ongetIdentifierType, which only considers the primary key type. This results in unexpected behavior—in this case, aClassCastExceptionwhen attempting to call the custom ID type's equals method.The fix replaces
getIdentifierTypewithgetIdentifierOrUniqueKeyType, ensuring thatisDirtycorrectly accounts for both primary keys and unique keys. This issue is demonstrated in the unit testManyToOneUniqueKeyReferenceWithCustomIdTest.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18764